-
Notifications
You must be signed in to change notification settings - Fork 31.5k
[Quantization] [Compressed Tensors] Support Transforms, Fix Tests #42887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @MekkCyber for quantization |
|
|
a65d99e to
d56f657
Compare
SunMarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall LGTM ! Just a few nits
tests/quantization/compressed_tensors_integration/test_compressed_tensors.py
Show resolved
Hide resolved
MekkCyber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix @kylesayrs
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
d56f657 to
77a0036
Compare
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
|
[For maintainers] Suggested jobs to run (before merge) run-slow: compressed_tensors_integration |
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=42887&sha=3a71ff |
|
Recent changes from #42882 ended up breaking this PR as implemented. This is because calling I'm moving Thanks |
|
Thanks @kylesayrs! As discussed offline, indeed it won't matter which weight is actually present in the checkpoint for tying them! Letting you with @SunMarc and @MekkCyber for the quantization part! |
Oh indeed, as most quants methods calling preprocess is actually calling |
Purpose
Background
Transforms are extra weights added to a model which improve accuracy recovery from quantization. These extra weights are required to be shared in order to reduce memory requirements of the model.
Prerequisites
Changes
0.13.1(to support transform features)apply_transform_configimplements_update_transforms_tied_weights, which leverages @Cyrilvallez 's refactoredtie_weightsfunctionality!Implemented in CT's
apply_transform_configExample
_tied_weights_keys:Testing
CompressedTensorsTest, added an online quip-style transformed model for testingSuggested Reviewers
@SunMarc @Cyrilvallez @Rocketknight1