Fix const parsing for dict inputs in chat schemas #41824
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
approved these changes
Oct 24, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing :)
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
* Fix const parsing for dict inputs * make fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found one more bug in chat schemas and updated the tests to cover it!
constnodes were not being handled correctly when the parent node had structured content.This PR also moves
test_chat_schema_utils.pytotest_chat_parsing_utils.pyto match the name of the actual fileutils/chat_parsing_utils.py.Tests may not be running in the CI yet but I ran them all locally and they're passing!