Delay and probably avoid unnecessary graph breaks in _upad_input of modeling_flash_attention_utils.py - #41097
Open
cyyever wants to merge 1 commit into
Open
Delay and probably avoid unnecessary graph breaks in _upad_input of modeling_flash_attention_utils.py#41097cyyever wants to merge 1 commit into
cyyever wants to merge 1 commit into
Conversation
cyyever
marked this pull request as draft
September 23, 2025 10:51
cyyever
force-pushed
the
flash_attn
branch
2 times, most recently
from
September 23, 2025 10:54
8cf2ae6 to
dc5f4fe
Compare
cyyever
marked this pull request as ready for review
September 23, 2025 10:57
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
cyyever
changed the title
Member
|
cc @Cyrilvallez for attention |
Member
|
Humm, I don't really see how this delays the graph break? Moreover, |
Contributor
Author
|
@Cyrilvallez It delays until |
Member
|
Yes, but the function is called only if |
Contributor
Author
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It works by refactoring
_get_unpad_data