Align assisted generate for unified signature in decoding methods #40657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit beb2b5f Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 16:03:25 2025 +0200 also standardize _get_stopping_criteria commit 15c2566 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 15:48:38 2025 +0200 watch super.generate() usages commit 67dd845 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 14:44:32 2025 +0200 ops commit 4655dfa Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 14:41:36 2025 +0200 wrong merge commit 4647814 Merge: a72c2c4 8564e21 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 14:36:15 2025 +0200 Merge branch 'main' of github.com:huggingface/transformers into fix-custom-gen-from-function2 commit a72c2c4 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 14:04:59 2025 +0200 ops5 commit e72f914 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 12:06:19 2025 +0200 ops4 commit 12ca97b Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 11:58:59 2025 +0200 ops3 commit 8cac6c6 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 11:43:03 2025 +0200 ops2 commit 4681a7d Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 11:40:51 2025 +0200 ops commit 0d72aa6 Merge: e0d47e9 5bb6186 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 11:37:28 2025 +0200 Merge branch 'remove-constrained-bs' into fix-custom-gen-from-function2 commit 5bb6186 Merge: 44973da b0db5a0 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 11:36:30 2025 +0200 Merge branch 'main' into remove-constrained-bs commit 44973da Merge: 1ddab4b 893d89e Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 11:29:48 2025 +0200 Merge commit '893d89e5e6fac7279fe4292bfa3b027172287162' into remove-constrained-bs commit e0d47e9 Merge: 88128e4 1ddab4b Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 10:52:50 2025 +0200 Merge branch 'remove-constrained-bs' into fix-custom-gen-from-function2 commit 88128e4 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Mon Sep 1 10:44:38 2025 +0200 fix custom generate args, refactor gen mode args commit 1ddab4b Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Sun Aug 31 21:03:53 2025 +0200 fix commit 6095fdd Merge: 4a8b6d2 04addbc Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 17:49:16 2025 +0200 Merge branch 'remove-constrained-bs' of github.com:manueldeprada/transformers into remove-constrained-bs commit 4a8b6d2 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 17:48:25 2025 +0200 restore and deprecate beam obkects commit 04addbc Merge: e800c78 becab2c Author: Manuel de Prada Corral <6536835+manueldeprada@users.noreply.github.com> Date: Thu Aug 28 14:38:29 2025 +0200 Merge branch 'main' into remove-constrained-bs commit e800c78 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 14:38:10 2025 +0200 tests gone after green commit 33971d2 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 14:07:11 2025 +0200 tests green, changed handling of deprecated methods commit ab30383 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 12:58:01 2025 +0200 tests fix commit ec74274 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 12:32:05 2025 +0200 ops commit 0fb1900 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 11:45:16 2025 +0200 whoops commit c946bea Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 11:35:36 2025 +0200 testing... commit 924c0de Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 11:22:46 2025 +0200 sweeep ready for tests commit b05aa77 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Thu Aug 28 11:13:01 2025 +0200 restore and deprecate constraints commit 9c7962d Merge: fceeb38 c17bf30 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Wed Aug 27 20:44:21 2025 +0200 Merge branch 'remove-group-bs' into remove-constrained-bs commit c17bf30 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Wed Aug 27 17:00:50 2025 +0200 fix test commit d579aee Merge: 822efd8 ed5dd29 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Wed Aug 27 16:04:31 2025 +0200 Merge branch 'main' of github.com:huggingface/transformers into remove-group-bs commit 822efd8 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Wed Aug 27 15:59:51 2025 +0200 aaand remove tests after all green!! commit 62cb274 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Wed Aug 27 11:48:19 2025 +0200 fix commit c89c892 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Wed Aug 27 11:45:20 2025 +0200 testing that hub works the same commit fceeb38 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Tue Aug 26 20:06:59 2025 +0200 draft commit 6a9b384 Merge: 8af3af1 58cebc8 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Tue Aug 26 15:00:05 2025 +0200 Merge branch 'main' of github.com:huggingface/transformers into remove-group-bs commit 8af3af1 Author: Manuel de Prada Corral <manueldeprada@gmail.com> Date: Tue Aug 26 11:55:45 2025 +0200 Squashed commit remove-constrastive-search
Contributor
Author
|
ok the usual suspect CSM is complaning, will fix that later |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…-assisted-generate
…ansformers into unify-assisted-generate
manueldeprada
commented
Sep 3, 2025
manueldeprada
commented
Sep 3, 2025
manueldeprada
commented
Sep 3, 2025
gante
reviewed
Sep 4, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Nice consolidation of the decoding methods' call! 🔥
A few comments with potential improvements
manueldeprada
changed the title
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: dia |
manueldeprada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gante let me know what do you think of something like this, it would make my life easier for #40652, which is still not ready for review. It also progresses towards the goal of a set of defined stages with readable general signatures.