Skip to content

Conversation

marcoom
Copy link

@marcoom marcoom commented Aug 31, 2025

What does this PR do?

This PR updates the model-card for the SAM (Segment Anything Model) model, as described in this issue, in an attempt to standardize all model-cards.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu please let me know if there are any changes. Thanks!

@marcoom
Copy link
Author

marcoom commented Sep 17, 2025

Hey @stevhliu, thanks for the update on #36979. I understand this PR may not be merged due to the automation plan. The changes here were tested and updated, so they might be useful as input for the final SAM model card.

It was a great learning experience to contribute — I’ll be happy to help again in future docs or issues. Thanks for your time and effort mantaining the project!

@stevhliu
Copy link
Member

Thanks again @marcoom, I appreciate your PR and apologize for not communicating earlier to avoid wasting your time. I'll keep this PR in mind when I get to the SAM model card! 🤗

@stevhliu stevhliu closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants