Skip to content

Avoid utils/check_bad_commit.py failing due to rate limit (requesting api.github.com) #39918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 5, 2025

What does this PR do?

39885 introduces ~70 new failed tests, and the check_bad_commit.py failed due to rate limit (I believe), see

https://github.com/huggingface/transformers/actions/runs/16739364088/job/47406733586

This PR stores the results of api.github.com requests, and reuse them if a commit is already in the cache.

@ydshieh ydshieh requested a review from Cyrilvallez August 5, 2025 14:05
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the expert!

@ydshieh ydshieh merged commit 369c99d into main Aug 5, 2025
15 checks passed
@ydshieh ydshieh deleted the avoid_check_bad_commit_failing branch August 5, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants