Fix ProphetNet forward to handle tuple encoder_outputs #39794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in ProphetNet where passing
encoder_outputs
as a tuple toforward()
would raise:AttributeError: 'tuple' object has no attribute 'last_hidden_state'
This happens because the
forward()
method assumesencoder_outputs
is aBaseModelOutput
when provided manually, while the docstring says it can be a tuple.Changes:
Added a check in
forward()
:Convert tuple
encoder_outputs
toBaseModelOutput
format before passing toProphetNetSeq2SeqModelOutput
.