Delete bad rebasing functions - #39672
Merged
Merged
Conversation
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
can you replace the exception on kernels to be Exception as e and can you use register instead of global mapping that I am doing?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
Ah, missed that! Wrong rebase indeed, thanks for fixing! |
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* remove outdated stuff * remove comment * use register * remove finally clause (to allow further check if fallback to sdpa) * general exception * add wrapper * revert check * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#39339 added back some functions that were not supposed to be here anymore!
cc @molbap for viz!