Fix invalid property #39384
Merged
Fix invalid property #39384
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <cyyever@outlook.com>
cyyever
force-pushed
the
invalid_property
branch
from
1c4e4af to
e3a60bb
Compare
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gptq, higgs |
|
Hi @cyyever, I'm not sure what makes those type hints invalid! I know that after |
|
@Rocketknight1 Python properties should not accept other parameters than |
|
Oh, I see! I completely misread, I thought this was about the type hint. You're entirely correct! |
Rocketknight1
approved these changes
Jul 15, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
Signed-off-by: cyy <cyyever@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ruff detects some invalid property definitions. This PR fixes them.