Skip to content

[BLIP] remove cache from Qformer #39335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Qformer doesn't use cache and is not generative, this PR deprecates it for one version. We'll remove all usage of cache in non-generative models after 4.55 :)

@zucchini-nlp zucchini-nlp requested a review from Cyrilvallez July 10, 2025 11:15
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although from the tests it looks like you need to update indices of the stuff that is returned with output_xxx!

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: blip_2, instructblip, instructblipvideo

@zucchini-nlp
Copy link
Member Author

run-slow: blip_2, instructblip, instructblipvideo

Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ['models/blip_2', 'models/instructblip', 'models/instructblipvideo']
quantizations: [] ...

@zucchini-nlp zucchini-nlp merged commit c30af65 into huggingface:main Jul 14, 2025
19 of 20 checks passed
rjgleaton pushed a commit to rjgleaton/transformers that referenced this pull request Jul 17, 2025
* remove cache from Qformer

* fix

* this was never correct...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants