Skip to content

[Bugfix] [Quantization] Remove unused init arg #39324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

[Bugfix] [Quantization] Remove unused init arg #39324

merged 1 commit into from
Jul 16, 2025

Conversation

kylesayrs
Copy link
Contributor

Purpose

Changes

  • Remove run_compressed from list of QuantizationConfig init kwargs

@kylesayrs
remove unused arg from ct config init
e102531 
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs mentioned this pull request Jul 10, 2025
Merged
ArthurZucker
ArthurZucker approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the CompressedTensorHFQuantizer does check quantization_config.run_compressed but it looks like its handled

@kylesayrs
Copy link
Contributor Author

Yeah, that's checking transformers.CompressedTensorsConfig.run_compressed, not compressed_tensors.QuantizationConfig.run_compressed

@ArthurZucker ArthurZucker merged commit 71818f5 into huggingface:main Jul 16, 2025
23 checks passed
rjgleaton pushed a commit to rjgleaton/transformers that referenced this pull request Jul 17, 2025
@kylesayrs @rjgleaton
[Bugfix] [Quantization] Remove unused init arg (huggingface#39324)
2916da7 
remove unused arg from ct config init

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jul 22, 2025
@kylesayrs @zucchini-nlp
[Bugfix] [Quantization] Remove unused init arg (huggingface#39324)
bda324d 
remove unused arg from ct config init

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylesayrs @ArthurZucker