Skip to content

Fix qwen2_5_vl tests #38845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 17, 2025
Merged

Fix qwen2_5_vl tests #38845

merged 9 commits into from
Jun 17, 2025

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 16, 2025

What does this PR do?

As usual, trying to update/fix some value mismatching or OOM to make CI better.

Passing now both on A10/T4 with torch 2.7.1

@ydshieh ydshieh requested a review from zucchini-nlp June 16, 2025 13:40
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the breakpoints, prob you wanted to delete them after debuggin 😄

@@ -416,6 +417,8 @@ def test_small_model_integration_test_batch(self):
'system\nYou are a helpful assistant.\nuser\nWhat kind of dog is this?\nassistant\nThe dog in the picture appears to be a Labrador Retriever. Labradors are known for their friendly and intelligent nature, making them popular choices',
'system\nYou are a helpful assistant.\nuser\nWhat kind of dog is this?\nassistant\nThe dog in the picture appears to be a Labrador Retriever. Labradors are known for their friendly and intelligent nature, making them popular choices',
] # fmt: skip

breakpoint()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need breakpoint?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I should have removed it before requesting review.

@ydshieh ydshieh merged commit c61ca64 into main Jun 17, 2025
15 checks passed
@ydshieh ydshieh deleted the fix_qwen2_5_vl branch June 17, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants