Fix incorrect width ratio calculation in Llama4 image processor #38842
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Llama4ImageProcessorFast
class (source), the image resizing ratios for height and width are incorrectly calculated using the image height for both dimensions:Here,
size
is defined as:This configuration is also present in the preprocessor_config.json:
Currently, the bug does not cause visible issues because the height and width are equal. However, this would lead to incorrect behavior if the dimensions were different.
Suggested Fix:
Update the width ratio calculation to use
size.width
instead ofsize.height
:This change ensures correct aspect ratio handling in cases where the input size is not square.