-
Notifications
You must be signed in to change notification settings - Fork 29.4k
Update altCLIP model card #38306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update altCLIP model card #38306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added some suggestions to make it simpler!
docs/source/en/model_doc/altclip.md
Outdated
<hfoption id="transformers-cli"> | ||
|
||
```python | ||
>>> from PIL import Image | ||
>>> import requests | ||
altCLIP does **not** require `transformers-cli` at inference time, but the tool is handy for quantisation (see next section). | ||
|
||
>>> from transformers import AltCLIPModel, AltCLIPProcessor | ||
</hfoption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this as well since it isn't supported
docs/source/en/model_doc/altclip.md
Outdated
|
||
[[autodoc]] AltCLIPProcessor | ||
## Attention visualisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed since it isn't supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there are still some unresolved comments. You also don't need to modify the other files testing_utils.py
and modeling_deit.py
.
Hi @stevhliu, |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Update altclip.md * Update altclip.md * Update altclip.md * Update altclip.md * Update altclip.md * Update altclip.md * Rename altclip.md to altclip.mdx * Rename altclip.mdx to altclip.md * Update altclip.md * Update altclip.md * Update altclip.md --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
What does this PR do?
As suggested in this issue - #36979 (comment) - this PR rewrites the altCLIP model card so it matches the standardized template that @stevhliu introduced in #36979.
Key points:
Check list
Who can review?
Hi @stevhliu !
I updated the altCLIP model card following the standard format.
Let me know what you think of it.
Happy to revise. Thanks!