[gemma3] fix bidirectional attention mask #38080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
[run-slow] gemma3 |
|
run-slow: gemma3 |
|
This comment contains run-slow, running the specified jobs: models: ['models/gemma3'] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
What I got with the current state, and a few more tweaks for gemma3 locally (for the weird image token 🙃 ) |
ArthurZucker
approved these changes
May 20, 2025
faaany
pushed a commit
to faaany/transformers
that referenced
this pull request
May 21, 2025
* fix attn mask * attn viz doesn't show yello cubes between images * bucketize made it hard with different number of crops * fixup
xvyv99
pushed a commit
to xvyv99/transformers
that referenced
this pull request
May 21, 2025
* fix attn mask * attn viz doesn't show yello cubes between images * bucketize made it hard with different number of crops * fixup
redmoe-moutain
pushed a commit
to redmoe-moutain/transformers
that referenced
this pull request
Jun 10, 2025
* fix attn mask * attn viz doesn't show yello cubes between images * bucketize made it hard with different number of crops * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #38053. Images cannot attend to future images but in current implementation we unmask attention within all images