Skip to content

prevent creating a view/leaf param for low rank optimizers w FSDP #37379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 1 commit into from
Apr 11, 2025
Merged

prevent creating a view/leaf param for low rank optimizers w FSDP #37379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,6 @@ def setup_low_rank_optimizer(
and args.optim_target_modules.replace("_", "-") == "all-linear"
)

target_params = []
target_params_names = []
for module_name, module in model.named_modules():
target_module_exists, is_regex = check_target_module_exists(
Expand All @@ -1378,12 +1377,12 @@ def setup_low_rank_optimizer(
if not target_module_exists and not all_linear:
continue

target_params.append(module.weight)
target_params_names.append(module_name + ".weight")

if len(target_params) == 0:
if len(target_params_names) == 0:
raise ValueError(f"No target modules found for {optimizer_name} ({args.optim_target_modules}).")

target_params = [p for n, p in model.named_parameters() if n in target_params_names]
non_target_params = [p for n, p in model.named_parameters() if n not in target_params_names]
optim_kwargs.update(optim_args)

Expand Down