Skip to content

Conversation

@EricWiener
Copy link
Contributor

@EricWiener EricWiener commented Apr 7, 2025

What does this PR do?

Fixes #36754

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qubvel qubvel marked this pull request as ready for review April 8, 2025 09:17
@qubvel qubvel self-requested a review April 8, 2025 09:17
Copy link
Contributor

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EricWiener!

@EricWiener
Copy link
Contributor Author

For sure and thanks for the quick review @qubvel ! Do you know if the failing tests are known to be flakey or could these failures be due to the slight difference in the type hints? Ex:

FAILED tests/models/kosmos2/test_modeling_kosmos2.py::Kosmos2ModelTest::test_generate_continue_from_past_key_values - AssertionError: Lists differ: [[86,[209 chars], 1, 1], [23, 21, 44, 83, 82, 86, 30, 54, 25, [277 chars] 25]] != [[86,[209 chars], 1, 45], [23, 21, 44, 83, 82, 86, 30, 54, 25,[278 chars] 25]]

@qubvel
Copy link
Contributor

qubvel commented Apr 8, 2025

That's unrelated test failures, waiting for CI to pass to be able to merge

@EricWiener
Copy link
Contributor Author

Hi @qubvel, could we please merge?

@qubvel qubvel merged commit 953196a into huggingface:main Apr 11, 2025
18 checks passed
@qubvel
Copy link
Contributor

qubvel commented Apr 11, 2025

Sure, thanks!

cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
* Fix issues

* Fix comment

---------

Co-authored-by: Pavel Iakubovskii <qubvel@gmail.com>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* Fix issues

* Fix comment

---------

Co-authored-by: Pavel Iakubovskii <qubvel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to load google/siglip2-base-patch16-naflex

2 participants