-
Notifications
You must be signed in to change notification settings - Fork 31.5k
Fix typing issues with SigLip2 #37356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing issues with SigLip2 #37356
Conversation
qubvel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EricWiener!
|
For sure and thanks for the quick review @qubvel ! Do you know if the failing tests are known to be flakey or could these failures be due to the slight difference in the type hints? Ex: |
|
That's unrelated test failures, waiting for CI to pass to be able to merge |
|
Hi @qubvel, could we please merge? |
|
Sure, thanks! |
* Fix issues * Fix comment --------- Co-authored-by: Pavel Iakubovskii <qubvel@gmail.com>
* Fix issues * Fix comment --------- Co-authored-by: Pavel Iakubovskii <qubvel@gmail.com>
What does this PR do?
Fixes #36754
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.