-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fast Conditional-DETR Processor #37071
base: main
Are you sure you want to change the base?
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
Hi @keetrap, before I dive deep into the code, could you check if it would be useful to use modular here, as this image processor seems to have some similarities with other DETR image processors? You can look at the modular files of Deformable DETR and RT DETR to see how it's done. Thanks for working on this! |
@yonigozlan Thanks for the review. I’ve added the modular file. The tests are failing here, but they’re passing locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks great @keetrap , last thing to do is make sure that both classes are tested in all image processing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! LGTM, but let's wait for @ArthurZucker final approval before
Related #36978
cc @yonigozlan