Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fast Conditional-DETR Processor #37071

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

keetrap
Copy link
Contributor

@keetrap keetrap commented Mar 28, 2025

Related #36978
cc @yonigozlan

Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft March 28, 2025 10:12
@keetrap keetrap marked this pull request as ready for review March 28, 2025 10:20
@github-actions github-actions bot requested review from ydshieh and yonigozlan March 28, 2025 10:20
@yonigozlan
Copy link
Member

Hi @keetrap, before I dive deep into the code, could you check if it would be useful to use modular here, as this image processor seems to have some similarities with other DETR image processors? You can look at the modular files of Deformable DETR and RT DETR to see how it's done. Thanks for working on this!

@keetrap
Copy link
Contributor Author

keetrap commented Mar 31, 2025

@yonigozlan Thanks for the review. I’ve added the modular file. The tests are failing here, but they’re passing locally.

Copy link
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks great @keetrap , last thing to do is make sure that both classes are tested in all image processing tests

Copy link
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM, but let's wait for @ArthurZucker final approval before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants