Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Mar 24, 2025

What does this PR do?

Use another repo. for Mistral3 processor testing

@ydshieh ydshieh requested a review from zucchini-nlp March 24, 2025 12:00
@github-actions github-actions bot marked this pull request as draft March 24, 2025 12:00
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@ydshieh ydshieh marked this pull request as ready for review March 24, 2025 12:01
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since we already touched Mistral3, I am thinking if slow model tests are also affected by gating the repo?

If yes, imo we need to ask access from bot rather than copying repo, because we need to test the code works with the latest official model.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Mar 24, 2025

slow model tests are running on our runners, where we have the bot token, but the tests needed to be decorated by require_rad_token.

I will update that, thank you for catching this.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Mar 24, 2025

run-slow: mistral3

@github-actions
Copy link
Contributor

This comment contains run-slow, running the specified jobs: This comment contains run-slow, running the specified jobs:

models: ['models/mistral3']
quantizations: [] ...

@ydshieh
Copy link
Collaborator Author

ydshieh commented Mar 24, 2025

The failing tests (slow) will be treated by

@Cyrilvallez (on slack)

It's fine thanks! As I thought, they all blew the memory up 😆 we'll use quantized version for the tests

@ydshieh ydshieh merged commit 340500b into main Mar 24, 2025
16 of 17 checks passed
@ydshieh ydshieh deleted the update_test branch March 24, 2025 13:36
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* fix

* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
soghomon-b pushed a commit to soghomon-b/transformers that referenced this pull request Aug 24, 2025
* fix

* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants