[chameleon] fix num image token check #36918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
zucchini-nlp
added
the
for patch
Closed
5 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 24, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM thanks for fixing
Member
Author
|
Processor tests failing are all Mistral3, need a read-token which I just added. Not sure yet if the bot has access to Mistral3 though |
9 tasks
ArthurZucker
pushed a commit
that referenced
this pull request
Mar 25, 2025
* [chameleon] fix num image token check * embed after merging image token * skip this also * mistral require_read_token
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* [chameleon] fix num image token check * embed after merging image token * skip this also * mistral require_read_token
soghomon-b
pushed a commit
to soghomon-b/transformers
that referenced
this pull request
Aug 24, 2025
* [chameleon] fix num image token check * embed after merging image token * skip this also * mistral require_read_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, reported by Harry as it affects vLLM internal tests. The error was never caught because apparently Chameleon tested only text inputs w/o images
Added tests for
Vision2Seqand made sure all green