Fix torch version guard at import #36907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
added
the
for patch
gante
approved these changes
Mar 23, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, thank you for correcting the pin!
|
hi thanks for fixing - is this a hotfix for 4.50.0? |
Member
Author
|
@geraldstanje1 yes, we will do patch release later today :) |
ArthurZucker
pushed a commit
that referenced
this pull request
Mar 25, 2025
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
soghomon-b
pushed a commit
to soghomon-b/transformers
that referenced
this pull request
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #36888 and fixes #36906. As per title, the kwargs we are using (
flatten_with_keys_fn) are available only from 2.3.0. We can also pin at 2.2.0 and pass it as positional argument, but thenflatten_with_keys_fnwill not be used in torch (from what I can see in torch repo)