VLMs: even more clean-up #36249
Merged
VLMs: even more clean-up #36249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
approved these changes
Feb 20, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Love this super() pattern, well done! 💛
zucchini-nlp
force-pushed
the
vlm-cleaner-code
branch
from
c80f67f to
b914f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleans up some code in VLMs, as we don't really need to override it. It will save us energy of copying a tiny change in
prepare_inputs_for_generationacross all modelsWe'll need to prioritize using the
super()whenever possible, imo, for future models! Less maintaining cost and less bugsRan generation tests + slow test for changed models, all green (except for those failing on
main)