fix: prevent second save in the end of training if last step was saved already #36219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
Author
|
Hi, these tests are flicking. Can we restart pipeline? |
shethaadit
approved these changes
Feb 18, 2025
NosimusAI
force-pushed
the
fix/second-save-on-steps-save
branch
from
a03067b to
46a8f22
Compare
Contributor
Author
|
@shethaadit @SunMarc can you merge? It says that 2 workflows awaiting approval, but they are completed. |
Member
|
just waiting a last review |
Member
|
Could you also try to add a test to this, that would be nice |
muellerzr
approved these changes
Feb 19, 2025
Contributor
muellerzr
left a comment
muellerzr
left a comment
There was a problem hiding this comment.
Thanks for the fix, all green from me after we add a test please!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@SunMarc @muellerzr @shethaadit could you approve pls. Added unit test. |
shethaadit
approved these changes
Feb 20, 2025
skshetry
added a commit
to treeverse/dvclive
that referenced
this pull request
Apr 29, 2025
skshetry
added a commit
to treeverse/dvclive
that referenced
this pull request
Apr 29, 2025
* ci: try to fix test-full also use 3.12 to run full tests * fix mypy errors * hf: fix deprecated arguments in transformers.TrainingArguments * tests: adjust assertions in test_huggingface_log_model Due to huggingface/transformers#36219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
To resolve the issue where the model is saved twice when using save_strategy="epoch", we need to prevent the redundant save at the end of training. The save triggered by the end of the last epoch is sufficient, so we skip the final save when the strategy is set to epoch.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.