Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 20, 2024

What does this PR do?

Let's rework it for more security later.

@ydshieh ydshieh requested a review from ArthurZucker December 20, 2024 14:18
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Better to just remove it or rename the extension for it to not be run no? Or do the # actually skip everything inside? If so, LGTM!

@ydshieh
Copy link
Collaborator Author

ydshieh commented Dec 24, 2024

OK, I will just remove it

@ydshieh ydshieh merged commit ccc4a5a into main Dec 24, 2024
11 checks passed
@ydshieh ydshieh deleted the disable_for_now branch December 24, 2024 09:53
ydshieh added a commit that referenced this pull request Jan 7, 2025
ydshieh added a commit that referenced this pull request Jan 20, 2025
* Revert "Disable  `.github/workflows/self-comment-ci.yml` for now (#35366)"

This reverts commit ccc4a5a.

* fix

* fix

* fix

* least permission

* add env

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
* Revert "Disable  `.github/workflows/self-comment-ci.yml` for now (huggingface#35366)"

This reverts commit ccc4a5a.

* fix

* fix

* fix

* least permission

* add env

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
* Revert "Disable  `.github/workflows/self-comment-ci.yml` for now (huggingface#35366)"

This reverts commit ccc4a5a.

* fix

* fix

* fix

* least permission

* add env

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants