Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position_ids in XLMRobertaXLForCausalLM.prepare_inputs_for_generation #35044

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Add position_ids in XLMRobertaXLForCausalLM.prepare_inputs_for_generation #35044

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d00520c
fix
ydshieh Dec 2, 2024
962cf42
fix
ydshieh Dec 2, 2024
f7d2ae5
cleanup
ydshieh Jan 6, 2025
3c444a2
style
ydshieh Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style
  • Loading branch information
@ydshieh
ydshieh committed Jan 6, 2025
commit 3c444a246663607cba38de7e114c242796281026
4 changes: 3 additions & 1 deletion src/transformers/models/xlm_roberta_xl/modeling_xlm_roberta_xl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,9 @@ def prepare_inputs_for_generation(self, input_ids, past_key_values=None, attenti
# Create missing `position_ids` on the fly
position_ids = None
if model_kwargs.get("position_ids") is None:
position_ids = create_position_ids_from_input_ids(input_ids, padding_idx=self.config.pad_token_id) # placed in kwargs for further processing (see below)
position_ids = create_position_ids_from_input_ids(
input_ids, padding_idx=self.config.pad_token_id
) # placed in kwargs for further processing (see below)

# cut decoder_input_ids if past_key_values is used
if past_key_values is not None:
Expand Down
Loading