Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adamw_torch_8bit #34993

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Support adamw_torch_8bit #34993

merged 3 commits into from
Jan 21, 2025

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Nov 28, 2024

What does this PR do?

Fixes #34893

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

cc @muellerzr

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Nov 30, 2024

@muellerzr Hi is there anything I need to update in this PR?

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @fzyzcjy ! LGTM ! Did you verify that this optimizer works (memory saving + training time ) as expected when using Trainer ?

@SunMarc SunMarc requested a review from ArthurZucker December 2, 2024 14:26
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Dec 2, 2024

Did you verify that this optimizer works (memory saving + training time ) as expected when using Trainer ?

I tried it before by subclassing and hacking Trainer before creating issue/PR, and yes it seems to work for me.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! 🤗

@ArthurZucker ArthurZucker merged commit dc10f79 into huggingface:main Jan 21, 2025
26 checks passed
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 21, 2025

You are welcome!

bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimic adamw_torch_4bit and have adamw_torch_8bit
5 participants