-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adamw_torch_8bit #34993
Support adamw_torch_8bit #34993
Conversation
cc @muellerzr |
@muellerzr Hi is there anything I need to update in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @fzyzcjy ! LGTM ! Did you verify that this optimizer works (memory saving + training time ) as expected when using Trainer ?
I tried it before by subclassing and hacking Trainer before creating issue/PR, and yes it seems to work for me. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding! 🤗
You are welcome! |
* var * more * test
* var * more * test
What does this PR do?
Fixes #34893
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.