Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #34458

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix CI #34458

merged 4 commits into from
Oct 29, 2024

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes CI which is currently red on many PRs. Caused by #34043 and #34026 when not all tests were fetched for run

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix!

Comment on lines +105 to +106
pt_model.generation_config.max_length = 5
flax_model.generation_config.max_length = 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be input_ids.shape[-1] + 5 or using max_new_tokens instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, could also be max-new-tokens. Interestingly after the linked PR max_length behaves same way as max_new_tokens

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zucchini-nlp
Copy link
Member Author

btw I can't merge this while other tests are failing, retriggering didn't help

@techkang
Copy link
Contributor

I think the model used for testing is too large, which casued the timeout error. I proposed a new PR: #34482 trying to fixed it by using a small model instead.

@zucchini-nlp zucchini-nlp merged commit 63ca6d9 into huggingface:main Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants