Fix CI #34458
Merged
Fix CI #34458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 28, 2024
ydshieh
reviewed
Oct 28, 2024
Comment on lines
+105
to
+106
| pt_model.generation_config.max_length = 5 | ||
| flax_model.generation_config.max_length = 5 |
There was a problem hiding this comment.
should it be input_ids.shape[-1] + 5 or using max_new_tokens instead?
There was a problem hiding this comment.
yeah, could also be max-new-tokens. Interestingly after the linked PR max_length behaves same way as max_new_tokens
|
btw I can't merge this while other tests are failing, retriggering didn't help |
|
I think the model used for testing is too large, which casued the timeout error. I proposed a new PR: #34482 trying to fixed it by using a small model instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes CI which is currently red on many PRs. Caused by #34043 and #34026 when not all tests were fetched for run