Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build image - move runners #33530

Merged
merged 3 commits into from
Sep 17, 2024
Merged

CI Build image - move runners #33530

merged 3 commits into from
Sep 17, 2024

Conversation

glegendre01
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's wait a check run before merging

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 17, 2024

The images are successfully built. The red (failed) jobs are just about the push to docker hub (permission issue with -test postfix)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me but would help if there was a bit more context on what this change is for

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 17, 2024

@amyeroberts It's just a new cluster (CPU-only) that @glegendre01 deployed.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@ydshieh ydshieh merged commit 3476c19 into main Sep 17, 2024
16 of 18 checks passed
@ydshieh ydshieh deleted the ci-move branch September 17, 2024 16:12
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
* move runners

* move runners

* move runners
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
* move runners

* move runners

* move runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants