-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSH #33451
Fix SSH #33451
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
0efa06f
to
2c9ca0f
Compare
2c9ca0f
to
768cde3
Compare
echo "SLACKCHANNEL=${{ secrets[format('{0}_{1}', github.actor, 'SLACK_ID')] }}" >> $GITHUB_ENV | ||
echo "${{ github.actor }}" | ||
github_actor=${{ github.actor }} | ||
github_actor=${github_actor/'-'/'_'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace -
by _
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
b20386f
to
45c436e
Compare
* fix * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
* fix * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
Fix
GitHub' secret can't contain
-
character. But we have @zucchini-nlpThis PR does a replacement of
-
by_