Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSH #33451

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix SSH #33451

merged 2 commits into from
Sep 16, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 12, 2024

What does this PR do?

Fix

GitHub' secret can't contain - character. But we have @zucchini-nlp

This PR does a replacement of - by _

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

echo "SLACKCHANNEL=${{ secrets[format('{0}_{1}', github.actor, 'SLACK_ID')] }}" >> $GITHUB_ENV
echo "${{ github.actor }}"
github_actor=${{ github.actor }}
github_actor=${github_actor/'-'/'_'}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace - by _

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ydshieh ydshieh merged commit 5ce0a11 into main Sep 16, 2024
10 of 11 checks passed
@ydshieh ydshieh deleted the ssh_dm_update branch September 16, 2024 09:08
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
* fix

* update

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
* fix

* update

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants