-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Whisper test] Fix some failing tests #33450
[Whisper test] Fix some failing tests #33450
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
It would be a good opportunity to use the |
There'll be failing tests though FYI, there's a lot of work to do around Whisper! |
Yeah I understand. (just want to make sure the tests fixed in this PR are passing). The core maintainers could still merge in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @ylacombe!
@ydshieh, do you know why this error happens ? |
No, it happens in some models and runs. It's more a infra issue I think. |
I re-triggered it. Let's see |
Still happening! |
Let me see what I can do manually. |
I pushed a commit to run slow ci on the (about to deploy) new cluster. Let me know how it goes 🙏 (before merge, let me revert my commits 🙏 ) |
Could you check if the fixed tests are passing in the following run ?
or download the artifact
and check the file |
Hey @ydshieh, they passed indeed ! Thanks for helping me on this, |
b1477fc
to
f9ce77c
Compare
Nice! Reverted! |
* Fix failing tensor placement in Whisper * fix long form generation tests * more return_timestamps=True * make fixup * [run_slow] whisper * [run_slow] whisper
* Fix failing tensor placement in Whisper * fix long form generation tests * more return_timestamps=True * make fixup * [run_slow] whisper * [run_slow] whisper
What does this PR do?
This PR proposes multiple simple fix to some Whisper failing tests:
return_timestamps=True
UPDATE: ready for review, I'll correct more tests in the coming days
cc @LysandreJik and @ydshieh