Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whisper test] Fix some failing tests #33450

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

ylacombe
Copy link
Contributor

@ylacombe ylacombe commented Sep 12, 2024

What does this PR do?

This PR proposes multiple simple fix to some Whisper failing tests:

  1. Fix failing tensor device
  2. Fix long-form integration tests that weren't using return_timestamps=True

UPDATE: ready for review, I'll correct more tests in the coming days

cc @LysandreJik and @ydshieh

@ylacombe ylacombe changed the title [Whisper test] Fix failing tensor device [Whisper test] Fix some failing tests Sep 12, 2024
@ylacombe ylacombe marked this pull request as draft September 12, 2024 15:15
@ylacombe ylacombe marked this pull request as ready for review September 12, 2024 15:33
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 12, 2024

It would be a good opportunity to use the run-slow in this PR

@ylacombe
Copy link
Contributor Author

There'll be failing tests though FYI, there's a lot of work to do around Whisper!

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 13, 2024

Yeah I understand. (just want to make sure the tests fixed in this PR are passing).

The core maintainers could still merge in that case.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @ylacombe!

@ylacombe
Copy link
Contributor Author

@ydshieh, do you know why this error happens ?
Bus error (core dumped)

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 13, 2024

No, it happens in some models and runs. It's more a infra issue I think.

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 13, 2024

I re-triggered it. Let's see

@ylacombe
Copy link
Contributor Author

Still happening!

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 16, 2024

Let me see what I can do manually.

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 16, 2024

I pushed a commit to run slow ci on the (about to deploy) new cluster. Let me know how it goes 🙏

(before merge, let me revert my commits 🙏 )

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 16, 2024

Could you check if the fixed tests are passing in the following run ?

https://github.com/huggingface/transformers/actions/runs/10885416563/job/30203010247?pr=33450

or download the artifact

https://github.com/huggingface/transformers/actions/runs/10885416563?pr=33450

and check the file summary_short.txt would be easier

@ylacombe
Copy link
Contributor Author

Hey @ydshieh, they passed indeed ! Thanks for helping me on this,
I'll merge once you revert the commit!

@ydshieh ydshieh force-pushed the fix-failing-labels-test-whisper branch from b1477fc to f9ce77c Compare September 16, 2024 14:43
@ydshieh
Copy link
Collaborator

ydshieh commented Sep 16, 2024

Nice! Reverted!

@ylacombe ylacombe merged commit 98adf24 into huggingface:main Sep 16, 2024
17 of 21 checks passed
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
* Fix failing tensor placement in Whisper

* fix long form generation tests

* more return_timestamps=True

* make fixup

* [run_slow] whisper

* [run_slow] whisper
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
* Fix failing tensor placement in Whisper

* fix long form generation tests

* more return_timestamps=True

* make fixup

* [run_slow] whisper

* [run_slow] whisper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants