[whisper] Clarify error message when setting max_new_tokens #33324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Sep 6, 2024
|
Thanks for opening this PR @benniekiss ! |
|
the failing test is here It seems that the old error message is hardcoded in the test. Should I go ahead and update it to the new message so they are in sync? |
|
Oh right, let's do this! It's a bit weird indeed, but let's just correct the test |
benniekiss
force-pushed
the
clarify_error_message
branch
from
17aaa48
to
4da7924
Compare
ylacombe
approved these changes
Sep 12, 2024
|
ofc! pleasure working with yall |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
…ace#33324) * clarify error message when setting max_new_tokens * sync error message in test_generate_with_prompt_ids_max_length * there is no self
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
…ace#33324) * clarify error message when setting max_new_tokens * sync error message in test_generate_with_prompt_ids_max_length * there is no self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR clarifies the error message returned when the length of the prompt tokens +
max_new_tokensexceeds themax_target_positionsof the whisper model.Addresses the discussion in #32571
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ylacombe