Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added quick clarification #33166

Merged
merged 2 commits into from
Aug 28, 2024
Merged

added quick clarification #33166

merged 2 commits into from
Aug 28, 2024

Conversation

DuyguA
Copy link
Contributor

@DuyguA DuyguA commented Aug 28, 2024

What does this PR do?

Closes #28882.
Minor addition to docs for clarifying BatchEncoding's batch_axis param.

Before submitting

  • [ x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ x] Did you read the contributor guideline,
    Pull Request section?
  • [ x] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • [ x] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker

LysandreJik
LysandreJik approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation and fix @DuyguA!

@LysandreJik LysandreJik merged commit 5c1027b into huggingface:main Aug 28, 2024
7 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
@DuyguA @zucchini-nlp
added quick clarification (huggingface#33166)
87bfa1d 
* added quick clarification

* cosmetics
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
@DuyguA @zucchini-nlp
added quick clarification (huggingface#33166)
34e102b 
* added quick clarification

* cosmetics
@DuyguA DuyguA deleted the minor/doc-update-batch-axis branch September 20, 2024 13:59
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
@DuyguA @itazap
added quick clarification (huggingface#33166)
ecac0b2 
* added quick clarification

* cosmetics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchEncoding won't prepend batch axis to python list, even prepend_batch_axis is True
2 participants
@DuyguA @LysandreJik