Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the FSDP Plugin in the trainer explicitly rather wait for it to be setup by accelerate #33085

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

winglian
Copy link
Contributor

What does this PR do?

See the corresponding PR here huggingface/accelerate#3033. Ultimately I want to see device_mesh support, but this brings the fsdp_plugin to parity with the deepspeed plugin in training args.

@ArthurZucker @muellerzr

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
This is the corresponding PR to huggingface/accelerate#3033 that will enable passing a device_mesh

@muellerzr muellerzr added the WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress label Aug 22, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants