Skip to content

Conversation

@Sai-Suraj-27
Copy link
Contributor

What does this PR do?

The utils/notification_service.py file requires huggingface_hub package.

from huggingface_hub import HfApi

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh @amyeroberts

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 21, 2024

Thank you @Sai-Suraj-27 . We should move to using .github/workflows/slack-report.yml, but at this moment, this PR makes sense.

@ydshieh ydshieh requested a review from amyeroberts August 21, 2024 15:38
Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The failing tests should have been resolved with some updates to the CI images. I can't re-trigger the CI runs, as they failed too long ago. @Sai-Suraj-27 could you push an empty commit to try and retrigger a run?

@Sai-Suraj-27
Copy link
Contributor Author

Thanks!

The failing tests should have been resolved with some updates to the CI images. I can't re-trigger the CI runs, as they failed too long ago. @Sai-Suraj-27 could you push an empty commit to try and retrigger a run?

Thanks for the review @amyeroberts. Done 👍🏻. All the tests are passing now.

@amyeroberts amyeroberts merged commit af638c4 into huggingface:main Aug 22, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…ngface#32891)

Added missing huggingface_hub installation to workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants