-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AutoConfig and AutoModel support for Llava-Next-Video #32844
Fix AutoConfig and AutoModel support for Llava-Next-Video #32844
Conversation
Oh, I see now. I changed hub models to underscore naming but didn't know transformers had it this way. IMO the best way here is to modify files on the hub to use For |
dd49f58
to
32f9ec0
Compare
Thanks! I have removed the AutoModel comit. But I think that model_type="llava_next_video" would be better because the "llava_next" model type name is also underscore. And the model_type in the implementation files were also "llava_next_video", which need to be consistent. transformers/src/transformers/models/llava_next_video/configuration_llava_next_video.py Line 95 in 5fd7ca7
|
@TKONIY fair enough. Can you run |
* Change llava-next-video.md file name into llava_next_video.md to make it compatible with implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Retriggered the tests which were failing with timeout
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Dear @amyeroberts, do you know when this commit will be merged into a released version of Transformers? It is important since vLLM's video support can be merged into the main branch only when Transformers can correctly load Llava-Next-Video by AutoConfig, which is fixed by this commit. And the pending video support also blocks other PRs. Therefore, it would be great if you could help us by adding this fixing to the next release. Thank you! |
@TKONIY All commits currently merged into main will be part of the next minor release (but not necessarily a patch release). Our release schedule is monthly, so v4.45 will probably be this week or the next |
@amyeroberts Thanks for the information. Really appreciate your work! |
What does this PR do?
Bug fix: Llava-Next-Video model cannot be loaded by AutoConfig and AutoModel.
model_type
with the config.json in hugging face.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp