Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests recurrent #32651

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Fix tests recurrent #32651

merged 11 commits into from
Aug 13, 2024

Conversation

molbap
Copy link
Contributor

@molbap molbap commented Aug 13, 2024

What does this PR do?

Continuation of #32649 since it seems RecurrentGemma tests failures were not caught

@molbap
Copy link
Contributor Author

molbap commented Aug 13, 2024

Only the tensorflow-examples are failing here, again, so let's see?
Not re-triggering the CI with the filtering, so people can take a look more easily if wanted

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts
Copy link
Collaborator

@molbap Are there any previously passing tests which now are being skipped with this change?

@molbap
Copy link
Contributor Author

molbap commented Aug 13, 2024

I don't think there are - if position_ids were absent in the signature, this test would indeed have failed

@molbap
Copy link
Contributor Author

molbap commented Aug 13, 2024

Just checked, only additional tests skipped are those coming from RecurrentGemma as far as I can tell
In previous PR:

================ 2843 passed, 5777 skipped in 111.91s (0:01:51) ================

now:

=========== 1 failed, 2846 passed, 5773 skipped in 108.18s (0:01:48) ===========

That's on one out of 5 parallel runs, of course

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing and checking the change in tests!

@molbap molbap merged commit c135783 into main Aug 13, 2024
25 checks passed
@molbap molbap deleted the fix_tests_recurrent branch August 13, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants