-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests recurrent #32651
Fix tests recurrent #32651
Conversation
Only the tensorflow-examples are failing here, again, so let's see? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@molbap Are there any previously passing tests which now are being skipped with this change? |
I don't think there are - if |
Just checked, only additional tests skipped are those coming from RecurrentGemma as far as I can tell ================ 2843 passed, 5777 skipped in 111.91s (0:01:51) ================ now:
That's on one out of 5 parallel runs, of course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing and checking the change in tests!
What does this PR do?
Continuation of #32649 since it seems RecurrentGemma tests failures were not caught