Gemma2: fix FA2 generation #32553
Merged
Gemma2: fix FA2 generation #32553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Aug 9, 2024
|
Yes, I'll add link to this PR in the internal slack thread for patches :) |
|
Already added 😉 |
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 16, 2024
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 20, 2024
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 20, 2024
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 20, 2024
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As reported in #32309 (comment) Gemma2 FA2 is broken in the latest release due to applying 4D mask when preparing inputs. FA2 expects a 2D mask so we can skip that step if FA2 is set
Ran the FA2 generate tests, everything passing, except for the Phi3 which is already fixed in another PR for patch release