support torch-speech #32537
Merged
support torch-speech #32537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itazap
requested review from
ArthurZucker,
gante and
amyeroberts
and removed request for
ArthurZucker
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I'm surprised we need both git-lfs and pypi-kenlm for torch-speech - they seem unrelated to speech models (particularly git-lfs). Do you know which parts of the code were failing without these? |
ArthurZucker
reviewed
Aug 8, 2024
| @@ -2,13 +2,14 @@ FROM python:3.10-slim | |||
| ENV PYTHONDONTWRITEBYTECODE=1 | |||
| USER root | |||
| ARG REF=main | |||
| RUN apt-get update && apt-get install -y time git pkg-config make git-lfs | |||
| RUN apt-get update && apt-get install -y time git g++ pkg-config make git-lfs | |||
There was a problem hiding this comment.
do we need g++ for pypi-kenlm?
There was a problem hiding this comment.
yes, didn't work without. same as in torch-tf-light
gante
reviewed
Aug 17, 2024
gante
approved these changes
Aug 17, 2024
| @@ -2,13 +2,14 @@ FROM python:3.10-slim | |||
| ENV PYTHONDONTWRITEBYTECODE=1 | |||
| USER root | |||
| ARG REF=main | |||
| RUN apt-get update && apt-get install -y time git pkg-config make git-lfs | |||
| RUN apt-get update && apt-get install -y time git g++ pkg-config make git-lfs | |||
| ENV UV_PYTHON=/usr/local/bin/python | |||
| RUN pip install uv && uv venv && uv pip install --no-cache-dir -U pip setuptools GitPython | |||
| RUN uv pip install --no-cache-dir --upgrade 'torch' --index-url https://download.pytorch.org/whl/cpu | |||
There was a problem hiding this comment.
Suggested change
| RUN uv pip install --no-cache-dir --upgrade 'torch' --index-url https://download.pytorch.org/whl/cpu | |
| RUN uv pip install --no-cache-dir --upgrade 'torch' 'torchaudio' --index-url https://download.pytorch.org/whl/cpu | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #32389 to support torch-speech, we need to install
git-lfsandpypi-kenlmcurrently causing failures on docker image like here
CC @ArthurZucker @gante