Skip to content

Hub test: avoid repo creation deadlocks #32151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Hub test: avoid repo creation deadlocks #32151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/models/auto/test_processor_auto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@ def test_push_to_hub_dynamic_processor(self):
random_repo_id = f"{USER}/test-dynamic-processor-{uuid4()}"
try:
with tempfile.TemporaryDirectory() as tmp_dir:
create_repo(random_repo_id, token=self._token)
# exist_ok=True to avoid unlikely deadlocks
create_repo(random_repo_id, token=self._token, exist_ok=True)
Copy link
Contributor

@amyeroberts amyeroberts Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd - given the name coming being generated with uuid, I'm surprised we're ever hitting a clash. Could you share a link to a ci run where this happens?

Copy link
Contributor Author

@gante gante Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyeroberts more than one case actually:

These two PRs are built on top of the same PR (#30910) 🤔

Important note: on these PRs, the failure is present at every commit!

Copy link
Contributor Author

@gante gante Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the name coming being generated with uuid, I'm surprised we're ever hitting a clash

agreed 😅 I didn't dive to find the root cause (perhaps something seed related?), since this fix seems to solve the case and should be harmless 👼

Copy link
Contributor Author

@gante gante Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amyeroberts ⚠️ Important note: on the PRs I linked above, the failure is present at every commit! (which shouldn't happen, because of the random uuid)

Copy link
Contributor

@amyeroberts amyeroberts Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this fix seems to solve the case and should be harmless 👼

Unfortunately not completely harmless! We want to make sure we're only creating and deleting the same repo in the test.

repo = Repository(tmp_dir, clone_from=random_repo_id, token=self._token)
processor.save_pretrained(tmp_dir)

Expand Down