Add method to retrieve used chat template #32032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Jul 22, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM, just want to make sur this is alright with you cc @Rocketknight1
Rocketknight1
approved these changes
Jul 22, 2024
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
This is a clean PR, and it makes sense to me. Thank you!
Member
|
@KonradSzafer if you pull the latest version of |
KonradSzafer
force-pushed
the
add-get-chat-template
branch
from
d52c60b to
8470940
Compare
Contributor
Author
|
@ArthurZucker @Rocketknight1 thanks for the review! Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new method that allows users to retrieve the chat template. It encapsulates the logic from the existing
apply_chat_templatemethod, enabling users to access the template without applying it.Motivation:
I saw that you plan to introduce simplifications for managing chat templates in the next release (#31733). Please let us know if you think this will be relevant, thanks!
@Rocketknight1 @ArthurZucker @clefourrier