Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Remove IS_GITHUB_CI #31147

Merged
merged 1 commit into from
May 30, 2024
Merged

Workflow: Remove IS_GITHUB_CI #31147

merged 1 commit into from
May 30, 2024

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

IS_GITHUB_CI is a global env variable that is never used anywhere in our repo, it's a copypasta from TRL / PEFT: https://github.com/huggingface/peft/blob/cb0bf077744d11524ec6f68d920f4cfe4ef3e8f3/Makefile#L48

cc @ydshieh

@younesbelkada younesbelkada requested a review from ydshieh May 30, 2024 15:18
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@younesbelkada younesbelkada merged commit 6bd511a into main May 30, 2024
8 checks passed
@younesbelkada younesbelkada deleted the remove-is-github-ci branch May 30, 2024 15:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants