Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non blocking support to torch DL's #30465

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Non blocking support to torch DL's #30465

merged 3 commits into from
Apr 24, 2024

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Apr 24, 2024

What does this PR do?

This PR brings in huggingface/accelerate#2685 to transformers.

TL;DR Accelerate's dataloaders can optimize send_to_device when sending the data to CUDA directly using non_blocking safely. This PR allows the user to configure that as part of the AcceleratorConfig via non_blocking=True.

It's also recommended to use pin_memory=True, so this will flag a warning letting the user know it's recommended if not enabled.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr merged commit 6ad9c8f into main Apr 24, 2024
21 checks passed
@muellerzr muellerzr deleted the muellerzr-non-blocking branch April 24, 2024 20:24
itazap pushed a commit that referenced this pull request May 14, 2024
* Non blocking support

* Check for optimization

* Doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants