Fix all torch pipeline failures except one #30290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Apr 17, 2024
| @@ -367,8 +367,8 @@ | |||
| "pt": (AutoModel,) if is_torch_available() else (), | |||
| "default": { | |||
| "model": { | |||
| "pt": ("google/vit-base-patch16-224", "29e7a1e183"), | |||
There was a problem hiding this comment.
revision not existing
ydshieh
commented
Apr 17, 2024
| @@ -1216,7 +1216,7 @@ def test_with_local_lm_fast(self): | |||
| @slow | |||
| def test_whisper_longform(self): | |||
| # fmt: off | |||
| EXPECTED_RESULT = """ Folks, if you watch the show, you know, I spent a lot of time right over there. Patiently and astutely scrutinizing the boxwood and mahogany chest set of the day's biggest stories developing the central headline pawns, definitely maneuvering an oso topical night to F6, fainting a classic Sicilian, nade door variation on the news, all the while seeing eight moves deep and patiently marshalling the latest press releases into a fisher's shows in Lip Nitsky attack that culminates in the elegant lethal slow-played, all-passant checkmate that is my nightly monologue. But sometimes, sometimes, folks, I. CHEERING AND APPLAUSE Sometimes I startle away, cubside down in the monkey bars of a condemned playground on a super fun site. Get all hept up on goofballs. Rummage that were discarded tag bag of defective toys. Yank out a fist bowl of disembodied doll limbs, toss them on a stained kid's place mat from a defunct dennies. set up a table inside a rusty cargo container down by the Wharf and challenged toothless drifters to the godless bughouse blitz of tournament that is my segment. Meanwhile.""" | |||
| EXPECTED_RESULT = " Folks, if you watch the show, you know, I spent a lot of time right over there. Patiently and astutely scrutinizing the boxwood and mahogany chest set of the day's biggest stories developing the central headline pawns, definitely maneuvering an oso topical night to F6, fainting a classic Sicilian, nade door variation on the news, all the while seeing eight moves deep and patiently marshalling the latest press releases into a fisher's shows in Lip Nitsky attack that culminates in the elegant lethal slow-played, all-passant checkmate that is my nightly monologue. But sometimes, sometimes, folks, I. CHEERING AND APPLAUSE Sometimes I startle away, cubside down in the monkey bars of a condemned playground on a super fun site. Get all hept up on goofballs. Rummage that were discarded tag bag of defective toys. Yank out a fist bowl of disembodied doll limbs, toss them on Saturday, Rusty Cargo, container down by the Wharf, and challenge toothless drifters to the godless bughouse lets of tournament that is my segment. MUSIC Meanwhile!" | |||
There was a problem hiding this comment.
this is sensible. Similar change is done in #30152
ydshieh
commented
Apr 17, 2024
| @@ -103,7 +103,7 @@ def run_pipeline_test(self, dqa_pipeline, examples): | |||
| @require_detectron2 | |||
| @require_pytesseract | |||
| def test_small_model_pt(self): | |||
| dqa_pipeline = pipeline("document-question-answering", model="hf-internal-testing/tiny-random-layoutlmv2") | |||
There was a problem hiding this comment.
this checkpoint doesn't contain all weights, and random init. doesn't reproduce in each run.
(LayoutLMv2PreTrainedModel._init_weights is not written to take into account LayoutLMv2VisualBackbone added later)
ydshieh
commented
Apr 17, 2024
| @@ -103,7 +103,7 @@ def run_pipeline_test(self, dqa_pipeline, examples): | |||
| @require_detectron2 | |||
| @require_pytesseract | |||
| def test_small_model_pt(self): | |||
| dqa_pipeline = pipeline("document-question-answering", model="hf-internal-testing/tiny-random-layoutlmv2") | |||
| dqa_pipeline = pipeline("document-question-answering", model="hf-internal-testing/tiny-random-layoutlmv2-for-dqa-test") | |||
There was a problem hiding this comment.
So I just load the checkpoint, save it and upload to another repo then use it
ydshieh
commented
Apr 17, 2024
| @@ -32,7 +32,7 @@ def test_small_model_pt(self): | |||
| audio_classifier = pipeline( | |||
| task="zero-shot-audio-classification", model="hf-internal-testing/tiny-clap-htsat-unfused" | |||
| ) | |||
| dataset = load_dataset("ashraq/esc50") | |||
| dataset = load_dataset("hf-internal-testing/ashraq-esc50-1-dog-example") | |||
There was a problem hiding this comment.
this is done in another PR. It is changed here again just for me to proceed fast while waiting the review of another PR.
I will resolve the conflict before merge.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Apr 17, 2024
ydshieh
force-pushed
the
fix_after_fix_torch_pip
branch
from
8c4fc8d
to
191d780
Compare
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Apr 18, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
ydshieh
added a commit
that referenced
this pull request
Apr 23, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix most torch pipeline failures. See comments in the changes