Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix setup #30147

Merged
merged 4 commits into from
Apr 9, 2024
Merged

[CI] Fix setup #30147

merged 4 commits into from
Apr 9, 2024

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Apr 9, 2024

What does this PR do ?

This PR skip the setup steps for some job since they don't need it. This regression was introduced in this PR cc @ydshieh .
The condition works fine : https://github.com/huggingface/transformers/actions/runs/8618527519

@SunMarc SunMarc requested a review from ydshieh April 9, 2024 15:38
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@SunMarc
Copy link
Member Author

SunMarc commented Apr 9, 2024

I'm going to merge this PR. @ydshieh said that it was okay since we have tiny changes.

@SunMarc SunMarc merged commit 6cdbd73 into huggingface:main Apr 9, 2024
8 checks passed
@ydshieh
Copy link
Collaborator

ydshieh commented Apr 9, 2024

he is so fast anyway 😆

ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* [CI] fix setup

* fix

* test

* Revert "test"

This reverts commit 7df416d.
itazap pushed a commit that referenced this pull request May 14, 2024
* [CI] fix setup

* fix

* test

* Revert "test"

This reverts commit 7df416d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants