-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model_summary.md - Restore link to Harvard's Annotated Transformer. #29702
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e06ca70
model_summary.md - Add link to Harvard's Annotated Transformer.
gamepad-coder c9e9090
model_summary.md - slight wording change + capitalize name of the paper
gamepad-coder 3d0ec4d
model_summary.md - moves the Annotated Transformer link in a praenthe…
gamepad-coder 9378f4d
model_summary.md - moves the Annotated Transformer link in a praenthe…
gamepad-coder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=== ✅ Suggestion Implemented ===
I actually do like that a lot more, thanks @stevhliu !
Updated my PR in two commits to match your suggestion.
(Minor fyi: Couldn't commit it directly because the suggestion parenthetical had an extra
)
)=== VS Code: Diff Screenshots ===
GitHub struggles with single-line diffs, so here's my local diff in VS Code.
Just OCD, but feel free to verify for yourself too :)
diff for 3d0ec4d -- note the oops, missing "has"
diff for 9378f4d -- "has" restored
And finally: current PR's overall diff with
main
from last weekThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are no more change requests, feel free to merge it whenever.
And if there are any typos I missed, feel free to directly update the PR.
Sidenote:
I do like the annotated link much much better next to the original Transformer link, but I was hesitant to add too much noise to the intro sentence as a newcomer contributer. So thanks for that suggestion. 👍
PS:
I really appreciate the responsiveness and culture in this project, thanks for the help and the positive experience. :)