Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newly added PVTv2 model to all README files. #29647

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

robinverduijn
Copy link
Contributor

@robinverduijn robinverduijn commented Mar 13, 2024

What does this PR do?

Recent changes added the PVTv2 model but did not update all READMEs. This PR fixes the check_copies.py failures from CircleCI by adding PVTv2 to all README files.

  • Also fixes a relative path for FastSpeech2Conformer model in README_ru.md

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum?
    Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes?
    Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@amyeroberts @khipp @FoamoftheSea

Also fix one relative path in README_ru.md.
@khipp
Copy link
Contributor

khipp commented Mar 14, 2024

LGTM!

PR #29647 and PR #29574 didn't have the updated utils/check_copies.py file yet. Running python utils/check_copies.py --fix_and_overwrite on the main branch now correctly applies the changes.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts amyeroberts merged commit b4b9625 into huggingface:main Mar 14, 2024
8 checks passed
@robinverduijn robinverduijn deleted the update-models-in-README branch March 14, 2024 16:46
itazap pushed a commit that referenced this pull request May 14, 2024
Add newly added models to all README files.

Also fix one relative path in README_ru.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants