Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Deformable Detr typo when loading cuda kernels for MSDA #29294

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fixed Deformable Detr typo when loading cuda kernels for MSDA #29294

merged 1 commit into from
Feb 26, 2024

Conversation

EduardoPach
Copy link
Contributor

What does this PR do?

Fixes a typo that was overlooked at #29133 when loading the cuda kernels for Deformable Detr

c.c. @amyeroberts

amyeroberts
amyeroberts approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Could you run the slow model tests on a GPU? Once we can confirm everything is passing we can merge 🤗

@EduardoPach
Copy link
Contributor Author

Thanks for fixing!

Could you run the slow model tests on a GPU? Once we can confirm everything is passing we can merge 🤗

Ran them on Colab and they all passed
image

@amyeroberts amyeroberts merged commit 3b8c053 into huggingface:main Feb 26, 2024
17 checks passed
itazap pushed a commit that referenced this pull request May 14, 2024
@EduardoPach
Fixed Deformable Detr typo when loading cuda kernels for MSDA (#29294)
9845b78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardoPach @amyeroberts