Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed the previous tracking URI setting logic to prevent clashes with original MLflow code. #29096

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Fix: Fixed the previous tracking URI setting logic to prevent clashes with original MLflow code. #29096

merged 5 commits into from
Mar 4, 2024

Commits on Feb 29, 2024

  1. Changed logic for setting the tracking URI.

    The previous code was calling the `mlflow.set_tracking_uri` function
    regardless of whether or not the environment variable
    `MLFLOW_TRACKING_URI` is even set. This led to clashes with the original
    MLflow implementation and therefore the logic was changed to only
    calling the function when the environment variable is explicitly set.
    seanswyi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2ceea7e View commit details
    Browse the repository at this point in the history
  2. Check if tracking URI has already been set.

    The previous code did not consider the possibility that the tracking URI
    may already be set elsewhere and was therefore (erroneously) overriding
    previously set tracking URIs using the environment variable.
    seanswyi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5cd0efa View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Removed redundant parentheses.

    Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
    seanswyi and amyeroberts authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    6281492 View commit details
    Browse the repository at this point in the history
  2. Fix docstring to reflect library convention properly.

    Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
    seanswyi and amyeroberts authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    36d4fb0 View commit details
    Browse the repository at this point in the history
  3. Fix docstring to reflect library convention properly.

    "Unset by default" is the correct expression rather than "Default to `None`."
    
    Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
    seanswyi and amyeroberts authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3be0505 View commit details
    Browse the repository at this point in the history