Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trainer test wrt DeepSpeed + auto_find_bs #29061

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Feb 16, 2024

What does this PR do?

Follow-up to #29057, changes the test to ensure it raises a not-implemented-error

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Will verify on our CI before merging (as local deepspeed won't install for me).

Can confirm passes: https://github.com/huggingface/accelerate/actions/runs/7932048373

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr
Copy link
Contributor Author

cc @amyeroberts good for review now that I verified tests pass :)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@muellerzr muellerzr merged commit 636b032 into main Feb 16, 2024
18 checks passed
@muellerzr muellerzr deleted the deepspeed-exception branch February 16, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants