-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MusicGen Melody #28819
Merged
Merged
Add MusicGen Melody #28819
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
853d2c0
first modeling code
ylacombe 2ff2f3d
make repository
ylacombe a3fa21f
still WIP
ylacombe 4c02db4
update model
ylacombe b141703
add tests
ylacombe 2b19612
add latest change
ylacombe eae18da
clean docstrings and copied from
ylacombe 2285db3
update docstrings md and readme
ylacombe cb8f4c5
correct chroma function
ylacombe 0ab4623
Merge branch 'main' into add-musicgen-melody
ylacombe c1e196d
correct copied from and remove unreleated test
ylacombe c8bf6c5
add doc to toctree
ylacombe f015753
correct imports
ylacombe c8c5a4e
add convert script to notdoctested
ylacombe 2cf5cfb
Add suggestion from Sanchit
ylacombe bce1aaf
Merge branch 'huggingface:main' into add-musicgen-melody
ylacombe 0e944af
correct get_uncoditional_inputs docstrings
ylacombe 1a03cd9
modify README according to SANCHIT feedback
ylacombe fded84d
add chroma to audio utils
ylacombe 133e486
clean librosa and torchaudio hard dependencies
ylacombe a70d0da
fix FE
ylacombe 34c8270
refactor audio decoder -> audio encoder for consistency with previous…
ylacombe fdd1743
refactor conditional -> encoder
ylacombe b13cbcf
modify sampling rate logics
ylacombe 2bb0adb
modify license at the beginning
ylacombe d06b327
refactor all_self_attns->all_attentions
ylacombe 7842840
remove ignore copy from causallm generate
ylacombe 8e7c128
add copied from for from_sub_models
ylacombe 8e1bc88
fix make copies
ylacombe 61eb704
add warning if audio is truncated
ylacombe e761acc
add copied from where relevant
ylacombe 96baf7d
remove artefact
ylacombe 357b416
fix convert script
ylacombe ebe4cde
fix torchaudio and FE
ylacombe aacf7ee
modify chroma method according to feedback-> better naming
ylacombe 3838361
refactor input_values->input_features
ylacombe a68c1a0
refactor input_values->input_features and fix import fe
ylacombe b174155
add input_features to docstrigs
ylacombe f9620b9
correct inputs_embeds logics
ylacombe 6b6d7cb
remove dtype conversion
ylacombe 8c1d8f8
refactor _prepare_conditional_hidden_states_kwargs_for_generation ->_…
ylacombe 4eface6
change warning for chroma length
ylacombe 2109479
Update src/transformers/models/musicgen_melody/convert_musicgen_melod…
ylacombe 3bfc793
change way to save wav, using soundfile
ylacombe 9cd463a
correct docs and change to soundfile
ylacombe 9c4aee1
fix import
ylacombe 0fa0274
Merge branch 'huggingface:main' into add-musicgen-melody
ylacombe 0535b57
fix init proj layers
ylacombe 87f4cf7
Merge branch 'huggingface:main' into add-musicgen-melody
ylacombe b36e802
remove line breaks from md
ylacombe 3fd2839
fix issue with docstrings
ylacombe 9f15d02
add FE suggestions
ylacombe 48c2c3f
improve is in logics and remove useless imports
ylacombe 9a43be0
remove custom from_pretrained
ylacombe cf89389
simplify docstring code
ylacombe bb69817
add suggestions for modeling tests
ylacombe fc33efb
make style
ylacombe ba4d732
update converting script with sanity check
ylacombe 5166259
remove encoder attention mask from conditional generation
ylacombe 755960a
Merge branch 'main' into add-musicgen-melody
ylacombe 8b9177f
Merge branch 'main' into add-musicgen-melody
ylacombe ad26dc9
replace musicgen melody checkpoints with official orga
ylacombe 7595256
rename ylacombe->facebook in checkpoints
ylacombe 2576806
fix copies
ylacombe 379d70b
remove unecessary warning
ylacombe 9795c6f
add shape in code docstrings
ylacombe b03b36d
add files to slow doc tests
ylacombe b434f8a
fix md bug and add md to not_tested
ylacombe ebeca43
Merge branch 'main' into add-musicgen-melody
ylacombe 604a4c8
make fix-copies
ylacombe 7bda3c3
Merge branch 'huggingface:main' into add-musicgen-melody
ylacombe 5863cf9
fix hidden states test and batching
ylacombe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix copies
- Loading branch information
commit 2576806ab235befc8bfa8bae0d49ce9f7dbd5608
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have a seperate file for the generation part like we do for whisper no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could make the modelling + generation code a lot cleaner for the MusicGen series! Although long-term, the issue would be fully resolved by a refactor to generate to make it more composable for audio models (as suggested by @gante)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we do this as a follow-up PR for MusicGen + MusicGen Melody? (so as not to mix two features into one PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed